Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overflow on empty multiproof #4564

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Sep 2, 2023

If leavesLen + proofLen is 0, the function will revert with overflow instead of the MerkleProofInvalidMultiproof error.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2023

🦋 Changeset detected

Latest commit: 708738c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@frangio frangio changed the base branch from master to audit/wip/2a-2b September 2, 2023 04:41
@frangio frangio requested a review from Amxx September 2, 2023 04:43
@Amxx Amxx merged commit a503ba1 into OpenZeppelin:audit/wip/2a-2b Sep 4, 2023
12 checks passed
@frangio frangio deleted the lib-1061 branch September 4, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants