Skip to content

Commit

Permalink
fix: make relative links absolute in nav for docs subdomain (#16360)
Browse files Browse the repository at this point in the history 
# Overview

Our shared nav resources have a mix of relative and absolute links. This
is not great!

It means we have to edit the actual HTML for inclusion on the docs site.
This PR does a find-and-replace to accomplish that.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-fix-nav-links/v2/)
I clicked on all the links this time.

## Changelog

Replace `href="/` with `href="https://opentrons.com/` across the board.

## Review requests

Any sneaky other link format I could have missed?

## Risk assessment

low. we will have to replicate this in the future if we have to update
the nav (and its new version doesn't fix this problem)
  • Loading branch information
@ecormany
ecormany committed Sep 26, 2024
1 parent e1c8460 commit e3380c0
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 46 deletions.
24 changes: 12 additions & 12 deletions api/docs/templates/v2/remote-footer.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
</div>

<div class="mt-12 md:mt-20 hidden sm:block">
<a href="/">
<a href="https://opentrons.com/">
<img class="h-8" src="https://opentrons.com/wp-content/uploads/2024/03/LOGO.svg" alt="Opentrons logo" />
</a>
</div>
Expand Down Expand Up @@ -276,11 +276,11 @@
<div class="hidden md:block col-span-2 sm:col-span-1">
<p class="text-white opentrons-body"><strong>Products</strong></p>
<div class="mt-4 flex flex-col space-y-2">
<a href="/products/opentrons-flex-robot/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Opentrons Flex</a>
<a href="/products/categories/modules/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Modules</a>
<a href="/products/categories/workstations/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Workstations</a>
<a href="/instrument-services/" target="_blank" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Services</a>
<a href="/products/ot-2-robot/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">OT-2</a>
<a href="https://opentrons.com/products/opentrons-flex-robot/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Opentrons Flex</a>
<a href="https://opentrons.com/products/categories/modules/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Modules</a>
<a href="https://opentrons.com/products/categories/workstations/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Workstations</a>
<a href="https://opentrons.com/instrument-services/" target="_blank" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Services</a>
<a href="https://opentrons.com/products/ot-2-robot/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">OT-2</a>
</div>
</div>
<div class="hidden md:block col-span-2 sm:col-span-1">
Expand All @@ -305,15 +305,15 @@
<div class="hidden md:block col-span-2 sm:col-span-1">
<p class="text-white opentrons-body"><strong>About</strong></p>
<div class="mt-4 flex flex-col space-y-2">
<a href="/about/mission/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Our Mission</a>
<a href="/about/events/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Events & Webinars</a>
<a href="/about/news/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">News</a>
<a href="/about/jobs/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Careers</a>
<a href="/partnerships/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">OEM Partnerships</a>
<a href="https://opentrons.com/about/mission/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Our Mission</a>
<a href="https://opentrons.com/about/events/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Events & Webinars</a>
<a href="https://opentrons.com/about/news/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">News</a>
<a href="https://opentrons.com/about/jobs/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">Careers</a>
<a href="https://opentrons.com/partnerships/" target="_self" class="opentrons-body text-brand-grey-light hover:text-brand-yellow">OEM Partnerships</a>
</div>
</div>
<div class="flex footer-app-button-container sm:col-span-4 col-span-2">
<a class="opentrons-outline rounded-full footer-app-button" href="/ot-app/">Download the Opentrons App</a>
<a class="opentrons-outline rounded-full footer-app-button" href="https://opentrons.com/ot-app/">Download the Opentrons App</a>
</div>

</div>
Expand Down
Loading

0 comments on commit e3380c0

Please sign in to comment.