Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

Upgrade yarn in front-end CI #764

Closed
kylemh opened this issue Oct 2, 2017 · 2 comments
Closed

Upgrade yarn in front-end CI #764

kylemh opened this issue Oct 2, 2017 · 2 comments

Comments

@kylemh
Copy link
Member

kylemh commented Oct 2, 2017

Currently on v0.24.something

We can upgrade to latest with no breaking changes, and receive performance benefits and bug fixes.

@jjhampton
Copy link
Member

The Docker build on CI is running yarn v0.24.4 - and I believe this is because we're specifying in the front-end Dockerfile to pull from the node:7 tag (NodeJS v7.10.1) on Docker Hub:

# Dockerfile
FROM node:7

The Node v7 Docker tags were removed from the official docker-node repo, since Node v7.10.1 is no longer maintained:
nodejs/docker-node@a2600f4

Interestingly enough, the Node v7.10.1 tags aren't even listed anymore in Docker Hub, though you can still pull them:
https://hub.docker.com/r/library/node/tags/
related discussion on docker-node repo

Node v8 Docker tag from the docker-node installs the newer version of Yarn (1.5.1). My local dev machine is running this version of Yarn and it works well: https://github.com/nodejs/docker-node/blob/master/8/Dockerfile

I suggest that we pull from node:8 in the Dockerfile (which uses Node v8.11.1) instead. That's the version that most current devs should be running on their machines (assuming they're staying up-to-date w/ Node), and is the active Node LTS. We also should avoid running odd-numbered Node versions (more unstable), since only even-numbered versions are eligible for LTS support (4,6,8, etc): https://github.com/nodejs/Release#release-plan

Upgrading to Node v8.11.1 will install the new version of Yarn (specified in this issue). I'm also seeing some inconsistencies w/ yarn install and the version of Yarn being used on step 8 when comparing various Docker builds on local dev machines (see Gist logs linked in OperationCode/operationcode_frontend#946) and build logs from CI - I'm hoping this would fix that.

We can give this a shot by changing one line in the front-end Dockerfile - thoughts? @kylemh @ohaiwalt

@kylemh
Copy link
Member Author

kylemh commented Apr 20, 2018

@kylemh kylemh closed this as completed Apr 20, 2018
jjhampton referenced this issue in OperationCode/operationcode_frontend Apr 21, 2018
jjhampton referenced this issue in OperationCode/operationcode_frontend Apr 21, 2018
Follow-on to 4611266
v8.11.1 is active stable LTS - we should strive to use these (even numbered major release)

v9.11.1 is the current release, but not guaranteed to be stable (odd-numbered major release)

see https://github.com/nodejs/Release#release-schedule
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants