This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
Fix issue w/ production CSS being generated in wrong order (Webpack) #946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved
Fixes #945 - caused by CSS being generated in out of order in production.
Description of changes
Updates the NPM dependency
extract-text-webpack-plugin
to v3.0.0, per the recommendation in the issue from the dependency repo here. Without the update, CSS files on production were being generated in the wrong order - bug was not occurring on dev environment served from webpack-dev-server.To Test Locally
Code reviewers will want to test locally w/ the Webpack production build. I ran into some errors following the Quickstart Guide production steps, so I had to go thru the following steps:
server.js
, comment out these lines:Install new dependency version and build production:
yarn
yarn run build
Start docker container:
docker-compose up -d --build
Visit
http://localhost:80
to test the production build on the docker container server