Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK-485 Hakemusmaksut #1550

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

OK-485 Hakemusmaksut #1550

wants to merge 55 commits into from

Conversation

vaeinoe
Copy link
Contributor

@vaeinoe vaeinoe commented Apr 22, 2024

This ended up being the main feature branch and "monolithic" feature PR for hakemusmaksut and other related ataru backend features.

  • New fields to form properties for payment type and default / hardcoded fees for processing and decision phases
  • API endpoint & service code for setting payment information (excluding kk / hakemusmaksut)
  • Inference logic for setting kk / hakemusmaksut payment info for a form based on given haku
  • Parse tutkintoon johtava & kohdejoukon tarkenne, used for the hakemusmaksu inference
  • Hakemusmaksu is dynamically determined by haku & hakukohde properties, so add it to form and haku on the fly whenever needed (from OK-529 dynamically add hakemusmaksu to form data when editing / filling #1560 )
  • Record hakemusmaksu state as a property of a person (with OID) to the database (from OK-553 hakemusmaksu payment states #1564 )
  • Logic for determining which persons and hakus need payments and what the state of the payment ought to be in case of linked oids and state conflicts (from OK-556 payment state logic for hakemusmaksu #1574 )

To avoid rounding errors and other weirdness, the payment sums are stored as decimal number strings (like with the current TUTU) and the internal payment validation / setting logic is done as BigDecimals.

@vaeinoe vaeinoe changed the title OY-485 Add payment info to form properties OK-485 Add payment info to form properties Apr 22, 2024
@vaeinoe vaeinoe force-pushed the OK-485-form-payment-properties branch from 52c3a05 to d0ecd6c Compare April 25, 2024 09:17
@vaeinoe vaeinoe marked this pull request as ready for review April 25, 2024 09:43
@vaeinoe
Copy link
Contributor Author

vaeinoe commented May 27, 2024

Rebase tuoreimman masterin päälle.

@vaeinoe vaeinoe force-pushed the OK-485-form-payment-properties branch from c3a4a07 to 2beb2ff Compare June 13, 2024 07:23
@vaeinoe vaeinoe changed the title OK-485 Add payment info to form properties OK-485 Hakemusmaksut Jun 18, 2024
@vaeinoe vaeinoe force-pushed the OK-485-form-payment-properties branch from db74f3c to e26ef83 Compare July 10, 2024 12:07
@vaeinoe
Copy link
Contributor Author

vaeinoe commented Jul 10, 2024

Rebase tuoreimman masterin päälle.

@hajoa hajoa force-pushed the OK-485-form-payment-properties branch 2 times, most recently from a435a35 to 8947599 Compare August 8, 2024 14:13
@hajoa hajoa force-pushed the OK-485-form-payment-properties branch from 8947599 to cc5952e Compare August 16, 2024 12:36
vaeinoe and others added 27 commits August 19, 2024 16:02
* OK-485 automatic kk payment inference logic for forms

* Maksutyypin asettaminen lomakkeelle

* Korjattu maksutietojen asettamista apply-update-form-details

* Korjattu schema

* Maksujen suuruudeksi voi asettaa nil, ei tallenneta default arvoja lomakkeelle

* Hintojen muunnos takasin merkkijonoiksi

* Maksutyyppi radio-buttonit ja testikorjauksia

* Sallitaan tutu käsittelymaksun asettaminen

* Korjattu maksutietojen asettamista, kun maksutietoihin ei ole tehty muutoksia

* Muutettu Lasku schema sisältämään reference ja origin

* Lisätty testejä, käyttöoikeustarkastus, käsittelymaksun summan asetus tutulle

* Käyttöoikeus testi

* Lisätty käännöksiä ja tyylittelyä

* Käsittelymaksu pakolliseksi tutu-maksuille

* Lisätty public configuraatioon default tutu-maksun summa


---------

Co-authored-by: Väinö Ala-Härkönen <vae@wonna.fi>
…-applications

OK-576 payment status to applications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants