-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OK-485 Hakemusmaksut #1550
Open
vaeinoe
wants to merge
55
commits into
master
Choose a base branch
from
OK-485-form-payment-properties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OK-485 Hakemusmaksut #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaeinoe
changed the title
OY-485 Add payment info to form properties
OK-485 Add payment info to form properties
Apr 22, 2024
vaeinoe
force-pushed
the
OK-485-form-payment-properties
branch
from
April 25, 2024 09:17
52c3a05
to
d0ecd6c
Compare
vaeinoe
commented
Apr 29, 2024
vaeinoe
commented
Apr 29, 2024
hajoa
reviewed
May 21, 2024
hajoa
approved these changes
May 27, 2024
vaeinoe
force-pushed
the
OK-485-form-payment-properties
branch
from
May 27, 2024 13:02
1c90d8c
to
c3a4a07
Compare
Rebase tuoreimman masterin päälle. |
vaeinoe
force-pushed
the
OK-485-form-payment-properties
branch
from
June 13, 2024 07:23
c3a4a07
to
2beb2ff
Compare
vaeinoe
changed the title
OK-485 Add payment info to form properties
OK-485 Hakemusmaksut
Jun 18, 2024
vaeinoe
force-pushed
the
OK-485-form-payment-properties
branch
from
July 10, 2024 12:07
db74f3c
to
e26ef83
Compare
Rebase tuoreimman masterin päälle. |
hajoa
force-pushed
the
OK-485-form-payment-properties
branch
2 times, most recently
from
August 8, 2024 14:13
a435a35
to
8947599
Compare
hajoa
force-pushed
the
OK-485-form-payment-properties
branch
from
August 16, 2024 12:36
8947599
to
cc5952e
Compare
OK-617 fix year data type
* OK-485 automatic kk payment inference logic for forms * Maksutyypin asettaminen lomakkeelle * Korjattu maksutietojen asettamista apply-update-form-details * Korjattu schema * Maksujen suuruudeksi voi asettaa nil, ei tallenneta default arvoja lomakkeelle * Hintojen muunnos takasin merkkijonoiksi * Maksutyyppi radio-buttonit ja testikorjauksia * Sallitaan tutu käsittelymaksun asettaminen * Korjattu maksutietojen asettamista, kun maksutietoihin ei ole tehty muutoksia * Muutettu Lasku schema sisältämään reference ja origin * Lisätty testejä, käyttöoikeustarkastus, käsittelymaksun summan asetus tutulle * Käyttöoikeus testi * Lisätty käännöksiä ja tyylittelyä * Käsittelymaksu pakolliseksi tutu-maksuille * Lisätty public configuraatioon default tutu-maksun summa --------- Co-authored-by: Väinö Ala-Härkönen <vae@wonna.fi>
…-status OK-623 filter by payment status
…-applications OK-576 payment status to applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being the main feature branch and "monolithic" feature PR for hakemusmaksut and other related ataru backend features.
To avoid rounding errors and other weirdness, the payment sums are stored as decimal number strings (like with the current TUTU) and the internal payment validation / setting logic is done as BigDecimals.