Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trumbowyg editor won't accept click in whole textarea #15362

Open
rwawr opened this issue Feb 19, 2024 · 3 comments
Open

Trumbowyg editor won't accept click in whole textarea #15362

rwawr opened this issue Feb 19, 2024 · 3 comments
Labels
Milestone

Comments

@rwawr
Copy link
Contributor

rwawr commented Feb 19, 2024

Describe the bug

In Orchard 1.7.2 and up, most of the area of the trumbowyg and wysiwig editors will not accept a click to focus the input. In previous versions (1.6.0 was the version I upgraded from), clicking anywhere in the editor pane would focus the input, but now, only the current line and one line below the current line accept input. Everywhere else, the cursor is the default cursor rather than the caret that indicates an input field, and clicking does nothing.
image

To Reproduce

Steps to reproduce the behavior:

  1. Cook a new Orchard Core 1.8.2 site using the "Agency" recipe
  2. In the admin panel, go to Content > Content Definition > Content Types, and Edit the Html widget type
  3. Edit the "Content" HtmlField field and select "Trumbowyg editor" or "Wysiwig editor" for "What type of editor should be used?"
  4. On the Design > Widgets page, add an Html Widget
  5. Attempt to click on the bottom half of the editor pane for the "Content" field and notice that the input does not receive focus

Expected behavior

The entire editor pane of the trumbowyg editor should accept a click to focus the input.

@rwawr rwawr added the bug 🐛 label Feb 19, 2024
@rwawr rwawr changed the title Trumbowyg editor issues (Most of trumbowyg editor won't accept click, focused/hovered buttons look bad in dark mode) Trumbowyg/wysiwig editor issues (Most of wysiwig/trumbowyg editor won't accept click, focused/hovered buttons look bad in dark mode) Feb 19, 2024
@Piedone Piedone changed the title Trumbowyg/wysiwig editor issues (Most of wysiwig/trumbowyg editor won't accept click, focused/hovered buttons look bad in dark mode) Trumbowyg editor won't accept click in whole textarea and focused/hovered buttons look bad in dark mode May 21, 2024
@Piedone
Copy link
Member

Piedone commented May 21, 2024

These are two separate issues. Could you please split the dark mode one out to a new issue?

The click behavior I'm pretty sure is related to a Trumbowyg update. We use 2.28.0, but the demo page on https://alex-d.github.io/Trumbowyg/, using 2.27.3, doesn't show this behavior.

@Piedone Piedone added this to the backlog milestone May 21, 2024
@rwawr rwawr changed the title Trumbowyg editor won't accept click in whole textarea and focused/hovered buttons look bad in dark mode Trumbowyg editor won't accept click in whole textarea May 22, 2024
@rwawr
Copy link
Contributor Author

rwawr commented May 22, 2024

@Piedone I split out the dark mode issue into #16137 and updated the comment/title for this issue to remove references to the styling bug.

@Piedone
Copy link
Member

Piedone commented May 22, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants