Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background and foreground colors for hovered wysiwig/trumbowyg editor buttons are almost indistinguishable #16137

Closed
rwawr opened this issue May 22, 2024 · 3 comments · Fixed by #16356
Milestone

Comments

@rwawr
Copy link
Contributor

rwawr commented May 22, 2024

Describe the bug

In dark mode, the foreground color of the wysiwig/trumbowyg editor buttons is almost indistinguishable from the background color when hovered or focused. This does not appear to affect 1.7.2, but I believe it does affect 1.8.0 and up.
image

To Reproduce

Steps to reproduce the behavior:

  1. Cook a new Orchard Core 1.8.2 site using the "Agency" recipe
  2. In the admin panel, go to Content > Content Definition > Content Types, and Edit the Html widget type
  3. Edit the "Content" HtmlField field and select "Trumbowyg editor" or "Wysiwig editor" for "What type of editor should be used?"
  4. On the Design > Widgets page, add an Html Widget
  5. Set the admin theme to dark mode and notice that hovering over any of the buttons in the trumbowyg/wysiwig editor makes the background white but does not adjust the foreground color to stand out against the white background.

Expected Behavior

Editor buttons should have a foreground color that stands out from background when focused/hovered.

@hishamco
Copy link
Member

@rwawr did you try it in the latest bits?

@rwawr
Copy link
Contributor Author

rwawr commented May 22, 2024

@hishamco Yes, I just synced my fork and tried again, and the issue is still occurring for me.

@sebastienros sebastienros added this to the 2.x milestone May 30, 2024
Copy link

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants