Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events before and after handling bulk imports #11532

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,5 @@ public virtual Task GetContentItemAspectAsync(ContentItemAspectContext context)
{
return Task.CompletedTask;
}

public Task BeforeImportAsync(IEnumerable<ImportContentContext> contentItems)
{
return Task.CompletedTask;
}

public Task AfterImportAsync(IEnumerable<ImportContentContext> contentItems)
{
return Task.CompletedTask;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
using System.Collections.Generic;
using System.Threading.Tasks;

namespace OrchardCore.ContentManagement.Handlers;
public interface IBulkContentHandler
hyzx86 marked this conversation as resolved.
Show resolved Hide resolved
hyzx86 marked this conversation as resolved.
Show resolved Hide resolved
Piedone marked this conversation as resolved.
Show resolved Hide resolved
{
Task ImportingAsync(IEnumerable<ImportContentContext> contentItems);
Task ImportedAsync(IEnumerable<ImportContentContext> contentItems);
}
hyzx86 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ public interface IContentHandler
Task LoadingAsync(LoadContentContext context);
Task LoadedAsync(LoadContentContext context);
Task ImportingAsync(ImportContentContext context);
Task BeforeImportAsync(IEnumerable<ImportContentContext> contentItems);
Task ImportedAsync(ImportContentContext context);
Task AfterImportAsync(IEnumerable<ImportContentContext> contentItems);
Task UpdatingAsync(UpdateContentContext context);
Task UpdatedAsync(UpdateContentContext context);
Task ValidatingAsync(ValidateContentContext context);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public DefaultContentManager(
IContentDefinitionManager contentDefinitionManager,
IContentManagerSession contentManagerSession,
IEnumerable<IContentHandler> handlers,
IEnumerable<IBulkContentHandler> bulkContentHandlers,
ISession session,
IContentItemIdGenerator idGenerator,
ILogger<DefaultContentManager> logger,
Expand All @@ -43,13 +44,16 @@ public DefaultContentManager(
_contentDefinitionManager = contentDefinitionManager;
Handlers = handlers;
ReversedHandlers = handlers.Reverse().ToArray();
BulkContentHandlers = bulkContentHandlers;
_session = session;
_idGenerator = idGenerator;
_contentManagerSession = contentManagerSession;
_logger = logger;
_clock = clock;
}

public IEnumerable<IBulkContentHandler> BulkContentHandlers { get; private set; }

public IEnumerable<IContentHandler> Handlers { get; private set; }
public IEnumerable<IContentHandler> ReversedHandlers { get; private set; }

Expand Down Expand Up @@ -648,7 +652,7 @@ public Task<ContentValidateResult> UpdateContentItemVersionAsync(ContentItem upd
public async Task ImportAsync(IEnumerable<ContentItem> contentItems)
{
var contentList = contentItems.Select(x => new ImportContentContext(x)).ToList();
await ReversedHandlers.InvokeAsync((handler, list) => handler.BeforeImportAsync(list), contentList, _logger);
await BulkContentHandlers.InvokeAsync((handler, list) => handler.ImportingAsync(list), contentList, _logger);

var skip = 0;

Expand Down Expand Up @@ -779,9 +783,7 @@ public async Task ImportAsync(IEnumerable<ContentItem> contentItems)
batchedContentItems = contentItems.Skip(skip).Take(ImportBatchSize);
}

await ReversedHandlers.InvokeAsync((handler, list) => handler.AfterImportAsync(list), contentList, _logger);


await BulkContentHandlers.InvokeAsync((handler, list) => handler.ImportedAsync(list), contentList, _logger);
}

public async Task UpdateAsync(ContentItem contentItem)
Expand Down