Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to background tasks and improve the UI #13046

Merged
merged 7 commits into from
Jan 17, 2023

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jan 6, 2023

Fix #13045

Here is a summary of the changes

  • New search bar was added to the list page
  • Technical Name is no longer visible. Instead we show a title.
  • The Create action was removed from the controller as we can never create a background task using a UI.
  • The Edit action will now create an settings-entry in the document if an entry does not exists.

Here are some screenshots after this PR

image

image

Here are some screenshots prior this PR

image

image

@hishamco
Copy link
Member

hishamco commented Jan 7, 2023

Are we agreed on that?

Is that title comes from the user input? if Yes, how we can guarantee that there's no duplicate. BTW I'm not against the idea, but sometimes we need to discuss before submitting a PR

@MikeAlhayek
Copy link
Member Author

The title is something you define in the Attribute. We still identify the task by it type's full name so even if we have name conflict, it should not matter.

@MikeAlhayek MikeAlhayek merged commit 751f9d3 into OrchardCMS:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user friendly title to background tasks instead of showing the technical name
3 participants