New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notifier cookie path #13654

Merged

hishamco merged 2 commits into OrchardCMS:main from rjpowers10:fix-notifier-cookie

May 14, 2023

Contributor

rjpowers10 commented May 5, 2023

Fixes #13653

Notification works for default tenant using /orchard

Notification works for tenant A using /orchard/tenantA

Making sure the standard case still works when there is no prefix at all


          Fix notifier cookie path

d68db2f

rjpowers10 marked this pull request as ready for review

May 5, 2023 14:45

Contributor Author

rjpowers10 commented May 5, 2023 •

edited

Loading

There may be other cookie path issues, such as

https://github.com/OrchardCMS/OrchardCore/blob/76d632475946b245e409dc2d579077b799106926/src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/Configuration/CookieOptionsConfiguration.cs#LL25C35-L25C35
OrchardCore/src/OrchardCore.Themes/TheAdmin/Assets/js/userPreferencesPersistor.js

Line 7 in 5fc8f0b

var key = tenant + '-adminPreferences';

The first example probably has the same problem as the notifier cookie. The second example isn't setting the path at all, so it defaults to /.


          Don't set the cookie path to blank

f27ec3f

jtkech approved these changes

View reviewed changes

hishamco merged commit cc52c8d into OrchardCMS:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet