Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CultureDictionaryRecordKey record struct #15413

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

hishamco
Copy link
Member

Addresses #11358 (comment)

@sebastienros
Copy link
Member

No hashcode, no IEqutable, no constructors ...

Just a ToString() and something like this:

public record struct Person
{
    public required string FirstName { get; init; }
    public required string LastName { get; init; }
};

@sebastienros
Copy link
Member

sebastienros commented Mar 8, 2024

@hishamco
Copy link
Member Author

@sebastienros anything else to add?

@sebastienros sebastienros merged commit 2f84a12 into main Mar 13, 2024
4 checks passed
@sebastienros sebastienros deleted the hishamco/CultureDictionaryRecordKey branch March 13, 2024 19:21
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants