Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description and names of the openId features #16697

Merged
merged 15 commits into from
Sep 11, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper-casing things like Server or Client isn't necessary (the GUI is not a spec 😄), so it's probably best to avoid it to keep it more readable, IMO.

src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Manifest.cs Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
MikeAlhayek and others added 9 commits September 10, 2024 11:30
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
@MikeAlhayek MikeAlhayek modified the milestones: 2.1, 2.x Sep 10, 2024
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
src/docs/reference/modules/OpenId/README.md Outdated Show resolved Hide resolved
MikeAlhayek and others added 2 commits September 11, 2024 15:57
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
Co-authored-by: Kévin Chalet <kevinchalet@gmail.com>
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) September 11, 2024 22:57
@MikeAlhayek MikeAlhayek merged commit 4a42891 into main Sep 11, 2024
7 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/open-id-descriptions branch September 11, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants