Fix GraphQL dynamic field conflicts #8669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think unit tests are worth it if we move to Hot Chocolate later on. |
|
Maybe not ... but you’d still want to test that scenario; regardless of the implementation |
|
I’m happy for it to go as it is btw; as in the current state it’s broken anyway ! |
|
I agree that it needs unit test but let's merge it and create an issue to create a unit test. |
Skrypt
approved these changes
Feb 25, 2021
carlwoodhouse
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5536
Caught me again today, so time to have a crack at it.
@carlwoodhouse not especially my area, but best I can tell it fixes it.
Can now add dynamic fields, to anything that has been preregistered by another builder.