Increase Dripper duration. #2125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
requested review from
sparrowDom,
DanielVF,
naddison36 and
shahthepro
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2125 +/- ##
=======================================
Coverage 61.24% 61.24%
=======================================
Files 66 66
Lines 3321 3321
Branches 862 862
=======================================
Hits 2034 2034
Misses 1284 1284
Partials 3 3 ☔ View full report in Codecov by Sentry. |
shahthepro
reviewed
Jul 9, 2024
| signature: "setDripDuration(uint256)", | ||
| args: [14 * 24 * 60 * 60], | ||
| }, | ||
| { |
There was a problem hiding this comment.
I don't think a rebase is necessary. Any reason for adding that?
There was a problem hiding this comment.
I reused the PR that decreased the dripper duration. I thought that it was good to rebase right after changing the dripper duration because the vault will receive a fresh token, and this ensures a smoother APY.
shahthepro
approved these changes
Jul 10, 2024
naddison36
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the OETH dripper time from 7 to 14 days.
The OETH dripper's duration was set to 7 days last January to increase the flow of funds from the dripper to OETH.
However, to adapt to the beacon chain sweep delay (approx. 9 days), we can increase the duration to match beacon chain specification.