Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment file for revoking admin role on bridged wOETH #2239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shahthepro
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.57%. Comparing base (4973efb) to head (e41c2f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files          75       75           
  Lines        3848     3848           
  Branches     1014     1014           
=======================================
  Hits         2177     2177           
  Misses       1668     1668           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • No contract deployed.
  • Deployed contract's verified code (and all dependencies) match the code in master
    • No contract deployed.
  • The transactions that interacted with the newly deployed contract match the deploy script.
    • No contract deployed.
  • Governance proposal matches the deploy script
    • revokeAdmin role on bridged wOETH

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants