-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM Buyback #2240
base: master
Are you sure you want to change the base?
ARM Buyback #2240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
+ Coverage 56.57% 56.58% +0.01%
==========================================
Files 75 76 +1
Lines 3848 3849 +1
Branches 1014 1014
==========================================
+ Hits 2177 2178 +1
Misses 1668 1668
Partials 3 3 ☔ View full report in Codecov by Sentry. |
ARM Buyback
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
"initialize(address,address,address,address,uint256)", | ||
[ | ||
cSwapper.address, // Swapper1InchV5 | ||
"0xF14BBdf064E3F67f51cd9BD646aE3716aD938FDC", // MS 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's look these up from addresses.mainnet
, instead of having them separately coded here.
@clement-ux Can you make the linter happy? Thanks. |
I was sure I'd done it before push. Sorry, fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only change would be getting the strategist address
"initialize(address,address,address,address,uint256)", | ||
[ | ||
cSwapper.address, // Swapper1InchV5 | ||
addresses.mainnet.MultiSig2OutOf9, // MS 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can get the strategist address with
const { strategistAddr } = await getNamedAccounts();
This is configured in the Hardhat config
Create a new buyback for ARM
Create a new buyback for ARM, using
WETH
asoToken
. This use the same contract asOETHBuyback.sol
andOUSDBuyback.sol
.Params
Using the same parameter at OETHBuyback.sol except for oToken.
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: