Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM Buyback #2240

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ARM Buyback #2240

wants to merge 8 commits into from

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Sep 17, 2024

Create a new buyback for ARM

Create a new buyback for ARM, using WETH as oToken. This use the same contract as OETHBuyback.sol and OUSDBuyback.sol.

Params

Using the same parameter at OETHBuyback.sol except for oToken.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
    • No smart contract changes.
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Sep 17, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 6b4498f

@clement-ux clement-ux marked this pull request as ready for review September 17, 2024 15:18
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (4973efb) to head (6b4498f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2240      +/-   ##
==========================================
+ Coverage   56.57%   56.58%   +0.01%     
==========================================
  Files          75       76       +1     
  Lines        3848     3849       +1     
  Branches     1014     1014              
==========================================
+ Hits         2177     2178       +1     
  Misses       1668     1668              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openzeppelin-code bot commented Sep 17, 2024

ARM Buyback

Generated at commit: 6b4498fd672c52e18b1bb9b6c8a8093298a572f6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
18
42
66
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

"initialize(address,address,address,address,uint256)",
[
cSwapper.address, // Swapper1InchV5
"0xF14BBdf064E3F67f51cd9BD646aE3716aD938FDC", // MS 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's look these up from addresses.mainnet, instead of having them separately coded here.

DanielVF
DanielVF previously approved these changes Sep 18, 2024
@DanielVF
Copy link
Collaborator

@clement-ux Can you make the linter happy? Thanks.

@clement-ux
Copy link
Contributor Author

@clement-ux Can you make the linter happy? Thanks.

I was sure I'd done it before push. Sorry, fixed now.

Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only change would be getting the strategist address

"initialize(address,address,address,address,uint256)",
[
cSwapper.address, // Swapper1InchV5
addresses.mainnet.MultiSig2OutOf9, // MS 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get the strategist address with

const { strategistAddr } = await getNamedAccounts();

This is configured in the Hardhat config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants