-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git support #75
base: master
Are you sure you want to change the base?
Git support #75
Conversation
CMakeLists.txt
Outdated
FetchContent_Declare( | ||
Boost | ||
GIT_REPOSITORY "https://github.com/boostorg/boost.git" | ||
GIT_TAG "boost-1.69.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the git version specified in 1 place, and string()
code set up to format it as needed in the URL and Git repo cases. This way when you upgrade to a new version of Boost, you aren't changing 3-4+ places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Note that you can always use FetchContent_Declare in the global CMake project before using add_subdirectory() on boost-cmake to chose the branch or tag you prefer.
Still, I moved those strings to option() as it can be more convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the confusion, I didn't mean a configuration setting. I meant just for maintainability, a "local" variable to store it to make it easier for the maintainers to update the version later. In the case where the user wants to override the version, they must also specify a tag or SHA1, so 1 variable doesn't quite cut it. In that case, yeah I agree, they need to use Declare.
516b4fe
to
e29f0a6
Compare
No description provided.