Linting with Ruff #1504
Merged
Linting with Ruff #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations to pyproject.toml, reorder linting steps
Zeitsperre
added
enhancement
github-actions
bot
added
sdba
coxipi
reviewed
Oct 17, 2023
coxipi
reviewed
Oct 17, 2023
coxipi
reviewed
Oct 17, 2023
coxipi
reviewed
Oct 17, 2023
|
For additional context, we still need to use |
coxipi
reviewed
Oct 17, 2023
coxipi
reviewed
Oct 17, 2023
coxipi
reviewed
Oct 17, 2023
|
Ok, I may have mixed manual and Ruff changes, you can tell me. It doesn't seem to be much different than what we had before. Sometimes more/less white space. It seems good. I'm not sure what could go wrong with PR really, what should I be looking for. It didn't change much of our earlier formatting, so it must be working more or less equivalently. |
|
need to remove mentions of pydocstyle in "contributing.rst" I think? |
…tions, ignore fewer rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
pydocstyleandpycodestyle, and removed most of the checking performed byflake8(flake8 still needed forflake8-alphabetizeandflake8-rst).pyproject.tomlwith Ruff-based equivalent linting configurationtox.iniandMakefileto use Ruff. Reordered order of linting calls to trigger more typical violations first.Does this PR introduce a breaking change?
Yes. Ruff is now a dev dependency, while
pycodestyleandpydocstyleare no longer required. The checks that were being performed by those libraries are now redundant thanks to the new configuration.Other information:
Ruff is a linter for Python (built with Rust) that is blazingly fast and has been in development for around 1.5 years. Ruff v0.1.0 was released today.