Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support robustness functions in xs.ensemble_stats #299

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Support robustness functions in xs.ensemble_stats #299

merged 4 commits into from
Dec 7, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Dec 6, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • No.
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • You can now directly provide an ensemble dataset to xs.ensemble_stats.
  • xs.ensemble_stats now supports the robustness-related functions from xclim.
  • Small bugfix in publish_release_notes

Does this PR introduce a breaking change?

Other information:

@RondeauG RondeauG mentioned this pull request Dec 6, 2023
Open
1 task
juliettelavoie
juliettelavoie approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RondeauG RondeauG merged commit 15f054a into main Dec 7, 2023
18 checks passed
@RondeauG RondeauG deleted the ensemble_stats branch December 7, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @juliettelavoie