Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for spatial.py, remove old 'region' #367

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Tests for spatial.py, remove old 'region' #367

merged 7 commits into from
Mar 15, 2024

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Mar 14, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Tests for the functions in xs.spatial
  • Small bugfix in creep_weights for an edge case where the grid is very small, n is high, and mode=wrap.
  • Refactored subset to separate into multiple smaller functions.

Does this PR introduce a breaking change?

  • For 2D grids, the grid resolution estimation will now take the maximum difference, instead of the difference of the first indexes. The impact should be minimal.
  • Remove old (deprecated) instances of region
  • Remove the deprecated xs.extract.clisops_subset()

CHANGES.rst Outdated Show resolved Hide resolved
@RondeauG RondeauG merged commit 36628a1 into main Mar 15, 2024
23 checks passed
@RondeauG RondeauG deleted the spatialtests branch March 15, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants