Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test conversions #372

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Test conversions #372

merged 3 commits into from
Mar 21, 2024

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Mar 21, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Tests for xclim_modules/conversions.py
  • Added context="hydro" to the precipitation conversion.
  • Fixed a bug in tasmin/max_from_dtr when dtr was in different units than tasmin/max.

Does this PR introduce a breaking change?

  • I changed dtr (the function) to dtr_from_minmax to avoid conflicts with dtr (the variable). This is only breaking if people directly used the Python file, which should be no one.

Other information:

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RondeauG RondeauG merged commit 0bae81b into main Mar 21, 2024
23 checks passed
@RondeauG RondeauG deleted the testconv branch March 21, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants