-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble reduction and changes to Ensembles #63
Conversation
Conflicts: xscen/ensembles.py
Question 1: Question 2: |
Co-authored-by: juliettelavoie <juliette.lavoie@hotmail.ca>
I added a couple checks before |
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Conflicts: xscen/ensembles.py
Co-authored-by: juliettelavoie <juliette.lavoie@hotmail.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beaucoup de commentaires qui ne sont au final que des affaires de styles, donc j'approuve et tu en fais ce que tu veux.
Je ne suis pas certain de voir ce qu'on pourrait porter dans xclim? Le check sur delta_kind
?
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Conflicts: HISTORY.rst
for more information, see https://pre-commit.ci
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai quelques petits commentaires sur les notebooks, mais sinon c'est beau!
Je me rend compte qu'on n'a pas réglé cette question. Des idées ? |
Je pense que toujours retourner 3 trucs c'est ok. |
Pull Request Checklist:
pre-commit
hooks are installed/active in my local clone ($ pre-commit install
)number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
New file
reduction.py
that contains a function to help build the criteria data and anxclim.ensembles._reduce
wrapper.Changes to
ensemble_stats
to:xclim.ensembles._robustness
functions.ensemble_stats
every time.The code that performs
common_attrs_only
has been moved toclean_up
.Removed the default
to_level
inclean_up
.New function
generate_weights
that uses metadata in Datasets to guess GCMs and RCMs and create weights accordingly.New function
unstack_id
to reverse-engineer IDs.generate_id
now also accepts DatasetsDoes this PR introduce a breaking change?
statistics / stats_kwargs
have been changed/eliminated inensemble_stats
, respectively.Other information: