Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: Initial r2s #294

Merged
merged 4 commits into from
Aug 1, 2024
Merged

raidboss: Initial r2s #294

merged 4 commits into from
Aug 1, 2024

Conversation

valarnin
Copy link
Collaborator

Did some testing in zone but not extensive.

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Jul 31, 2024
ui/raidboss/data/07-dt/raid/r2s.ts Outdated Show resolved Hide resolved
ui/raidboss/data/07-dt/raid/r2s.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the needs-review Awaiting review label Jul 31, 2024
Co-authored-by: xiashtra <91220277+xiashtra@users.noreply.github.com>
@github-actions github-actions bot added the needs-review Awaiting review label Jul 31, 2024
@Legends0
Copy link
Collaborator

Legends0 commented Aug 1, 2024

I think the Centerstage and Outerstage combo triggers could use a durationSeconds as the tts is still talking after the text expires. I used 9s.

Reducing the output text to this also made it more understood to me:
Under Intercards => Out => Cards
Out Cards => Intercards => Under

The R2S Headmarker Spread call I think should just go to those with the marker and not everyone. There's multiple ways to do this strat though.

@github-actions github-actions bot removed the needs-review Awaiting review label Aug 1, 2024
@github-actions github-actions bot added the needs-review Awaiting review label Aug 1, 2024
@Legends0 Legends0 self-requested a review August 1, 2024 02:30
@github-actions github-actions bot removed the needs-review Awaiting review label Aug 1, 2024
@valarnin valarnin merged commit ad85807 into OverlayPlugin:main Aug 1, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Co-authored-by: xiashtra <91220277+xiashtra@users.noreply.github.com> ad85807
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
Co-authored-by: xiashtra <91220277+xiashtra@users.noreply.github.com> ad85807
@Battler624
Copy link

I haven't done this a lot but this is the second week in a row i notice this so i figured i'd report it.
I was using Gyoten while looking the the timeline of the poison sting (drop) and honestly its just plain wrong by around 3/4 of a second? I do not have exact numbers and idk how to provide them but everytime I dashed at the 0.0 mark I'd drop the puddle in the middle of the arena.

The one time I didn't drop it in the middle was when I had the second drop and I dashed when the third drop was at 4.3s left.

If there is anything I can do to help fix this, please do tell me I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raidboss /ui/raidboss module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants