Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postinit #2

Merged
merged 4 commits into from
May 3, 2016
Merged

Remove postinit #2

merged 4 commits into from
May 3, 2016

Conversation

ceridwen
Copy link
Collaborator

This is big but in many places boring. The brief summary of changes:

  • Removed parent attribute from nodes.
  • Removed postinit and combined its arguments into __init__.
  • Made arguments for node __init__ calls mandatory, exept for lineno/col_offset.
  • Made calls to node constructors use keywords for their arguments, to make the code easier to read.

There are still some TODOs in the code reflecting places where things either require more work that's already planned or I don't know how to solve them right now.

@PCManticore PCManticore merged commit 3885411 into master May 3, 2016
@ceridwen ceridwen deleted the remove_postinit branch May 3, 2016 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants