Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jit: correctly implement utf_continue() for utf16 #168

Merged
merged 1 commit into from
Dec 3, 2022
Merged

jit: correctly implement utf_continue() for utf16 #168

merged 1 commit into from
Dec 3, 2022

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Dec 3, 2022 •
edited
Loading

Resulting in a constant false result in aarch64 when using SIMD

@carenas
jit: correctly implement utf_continue() for utf16
0328f39 
Resulting in a constant false result.
zherczeg
zherczeg approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch

@zherczeg zherczeg merged commit 8d56880 into PCRE2Project:master Dec 3, 2022
@carenas carenas deleted the winarm branch December 3, 2022 20:46
@SolitaryGrass SolitaryGrass mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zherczeg zherczeg zherczeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carenas @zherczeg