Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ucptest updates #199

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Ucptest updates #199

merged 2 commits into from
Feb 1, 2023

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Jan 30, 2023

The first patch, just updates the output from ucptest, which has been out of sync one way or another since the Bidi changes. Some of the results at least in testoutput2 might not be correct, but at least this way they are visible.

The second patch does fix a minor issue in the CASELESS_RESTRICT code that was just merged and another old bugs from ucptest that I found while testing as well as further cleanups

Last sync with 1a5fcd (Remove unused variables in ucptest.c and update test data
for added properties, 2022-04-25), and showing significant differences.
@PhilipHazel
Copy link
Collaborator

Looks reasonable to me, but I'm going to finish current work on PCRE2_EXTRA_ASCII_xxx before trying to merge your patches. (I consider myself to be a Git novice and I want to keep things simple if possible.)

@PhilipHazel PhilipHazel marked this pull request as ready for review February 1, 2023 15:38
@PhilipHazel PhilipHazel merged commit 72c9b57 into PCRE2Project:master Feb 1, 2023
@PhilipHazel
Copy link
Collaborator

After merging this and the Unicode update, I see a lot of differences in the ucptestdata output. I'm wondering if something has gone wrong somewhere. The main PCRE2 tests run clean.

@carenas
Copy link
Contributor Author

carenas commented Feb 1, 2023

I think we have an old bug with boolean properties but still unsure of its impact, as mentioned before not all changes in the ucptestdata output made sense.

Also I didn't re-run ucptest with the Unicode update, so output changes from additional characters are expected; will rebase my changes, sorry about that.

@PhilipHazel
Copy link
Collaborator

It may be the Unicode update that's the problem. I am in the process of merging the other PCRE2_EXTRA_ASCII options, but have to stop now until tomorrow, when I hope I'll be able to push the result. Then I must do the documentation but after that I'll take a closer look at the properties stuff - I've forgotten the details so will have to relearn how the code works, and where all the data comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants