ci: add very basic 64bit Windows DEV job #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the original 32bit job and add a basic 64bit one that avoids the code that is still not warning free. While at it, refactor a recent compile fix to avoid a runtime assert.
zherczeg
requested changes
Sep 18, 2024
|
Is this ready for merging? I'm not sure whether the discussion is still active or not. |
|
Ok, lets merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job should at least ensure the library builds cleanly (although without JIT) and creates a DLL.
Its not as verbose as the original MSVC job (which has been renamed so it is clear it is 32bit) so that any warnings are clearly visible if building
pcre2grep,pcre2testor JIT is enabled.