Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic.PHP.LowerCaseKeyword: require lowercase anonymous class keyword #597

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

maryo
Copy link
Contributor

@maryo maryo commented Aug 16, 2024

Description

Generic.PHP.LowerCaseKeyword: require lowercase anonymous class keyword

Suggested changelog entry

Generic.PHP.LowerCaseKeyword: require lowercase anonymous class keyword

Related issues/external references

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maryo, thanks for this PR. I'll happily accept this change.

Just two small nitpicks:

  1. The "additional token targets" array is ordered alphabetically, but the new token is not added in the right alphabetical place.
  2. Would be nice to also have a test where the class keyword for an anonymous class is already in the correct case (to safeguard against false positives).

Let me know if you prefer I fix these up when merging.

@maryo maryo force-pushed the lowercase-keyword-anon-class branch from 5023c5c to 5759956 Compare August 17, 2024 16:18
@maryo
Copy link
Contributor Author

maryo commented Aug 17, 2024

@jrfnl

Let me know if you prefer I fix these up when merging.

Thanks, fixed

@jrfnl jrfnl added this to the 3.10.x Next milestone Aug 17, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maryo! I will merge this once the build has passed.

@jrfnl jrfnl merged commit a30d7bd into PHPCSStandards:master Aug 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants