Video embed is broken

[crazysix]

The video embed appears to be broken. On the dev branch, if I run Sample_03_Video.php and attempt to open the pptx I get an error.

The xml looks a bit different than a slide that I manually add a video to. The odp file is also not working, but I am mostly looking at pptx. I am on PowerPoint 16.54 on a mac. I am attaching my sample (testvideo.pptx) and the output from the sample (Sample_03_Video.pptx).
Sample_03_Video.pptx
testvideo.pptx

[potofcoffee]

I can confirm this is broken.

At least part of the problem is here:

PHPPresentation/src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php

Line 1318 in f5907e1

$objWriter->writeAttribute('r:embed', ((int) $shape->relationId + 1));

This won't create a correct relationship id, since $shape->relationId is a string like rId2 and can't be cast into an int.

However, that's only part of the problem. When I edit this manually to the correct relationship id, PowerPoint will open the presentation, but say that the video file was not found.

[potofcoffee]

Correction: With the above fix, PowerPoint finds and correctly plays the video. The only thing not working is a thumbnail display when the video is stopped. This would require another relationship with a thumbnail image. However, that's a big step which would probably introduce new dependencies to automatically create thumbnails from videos when packing the .pptx file.

[zmip]

Did this ever work? And were thumbnails created automatically back when it worked?