Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1505 #1525

Merged
merged 4 commits into from
Jun 19, 2020
Merged

Fix for #1505 #1525

merged 4 commits into from
Jun 19, 2020

Commits on Apr 28, 2020

  1. Merge pull request #1 from PHPOffice/master

    Resync with base project
    oleibman committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    1861412 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Merge pull request #2 from PHPOffice/master

    Sync with Base
    oleibman committed May 19, 2020
    Configuration menu
    Copy the full SHA
    7d58ba8 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Merge pull request #3 from PHPOffice/master

    Sync Up With Base
    oleibman committed May 25, 2020
    Configuration menu
    Copy the full SHA
    79d024f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Fix for #1505

    This problem is the same as #1238, which was resolved by #1239.
    For that issue, the fix was to check in one place whether
    $this->mapCellXfIndex[$xfIndex] was set before using it.
    The sample spreadsheet supplied as a description for this
    problem had exactly the same problem in 2 other places in the code.
    In addition, there were 7 other places in the code where that
    particular item was used unchecked. This fix corrects all 9 locations.
    The spreadsheet supplied with the problem is used as the basis
    for some new tests, which particularly test column dimensions
    and styles, the problems involved in this case.
    oleibman committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    b5eeabe View commit details
    Browse the repository at this point in the history