Zoom scale fix #350
Closed
Zoom scale fix #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eec8d1a.
Some computer programs will output xlsx files that do not compare 100% to the standards. Excel will open the file without any problem. setZoomScaleNormal() should throw exception when manually setting the scale to less than or equals 0, but when reading files, we should be able to read a file with such error, as Excel does.
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
Some computer programs will output xlsx files that do not compare 100% to the standards. Excel will open the file without any problem. setZoomScaleNormal() should throw exception when manually setting the scale to less than or equals 0, but when reading files, we should be able to read a file with such error, as Excel does. Closes PHPOffice#350
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Some computer programs that export excel files has a small error in their files where zoomScaleNormal="0" in the XML. I opened the file in 7zip and saw the problem.
Excel will open the file without any problems.
I agree that the methods in SheetView should throw exceptions when manually editing files in PhpSpreadsheet. But when reading files, we should be a little nicer, so our customers won't have to fix their files in Excel before importing to our system.