Bugfix for issue: xls file cause the exception during open by Xls reader #402 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 4, 2018 13:55
ignore some exception in property stream
…HPOffice#325 Bugfix: replace explode by "!" with special function, that extracts sheet name from reference
…s crash PHPOffice#325 Bugfix: replace explode by "!" with special function, that extracts sheet name from reference" This reverts commit b349ea3
|
@chorry seems to have identified 4b4831b as the culprit. Any reason you went with catching exception, rather that reverting the commit ? |
…der PHPOffice#402 revert commit 4b4831b with adding exceptions
PowerKiKi
requested changes
Oct 3, 2018
…der PHPOffice#402 adding unit tests for OLERead and Reader\Xls, also adding changelog entry
…der PHPOffice#402 codestyle fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore some exception in property stream
This is:
Checklist:
Manually tested with this .xls file:
test.zip