Exact match in VLOOKUP now returns first match #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spreadsheet software before)
frantzmiccoli
force-pushed
the
develop
branch
from
fac6808
to
a69c360
Compare
|
Thanks ! I merged with a few modifications |
guillaume-ro-fr
pushed a commit
to guillaume-ro-fr/PhpSpreadsheet
that referenced
this pull request
Jun 12, 2019
It was inconsistent with spreadsheet software before. Closes PHPOffice#809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
I stumbled upon a case where the value of a VLOOKUP was incorrectly returned compared with Excel.
I have also observed that PHP associative sorting does not preserve key order (for keys which have the same value), which explain the extra test on line 729. See https://gist.github.com/frantzmiccoli/bd03395b8fc831c67828718192c214b8 if you wish to test for yourself with
asort.uasortbehaves the same way but the gist was quicker to write with asort.