[XShape] Xshape is alternative for flatten op #10088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lite/operators/flatten_op.cc
Outdated
| @@ -80,21 +80,26 @@ bool FlattenOp::AttachImpl(const cpp::OpDesc &opdesc, lite::Scope *scope) { | |||
|
|
|||
| bool Flatten2Op::CheckShape() const { | |||
| FlattenOp::CheckShape(); | |||
| CHECK(param_.xshape); | |||
| if (has_xshape_) CHECK(param_.xshape); | |||
lite/operators/flatten_op.cc
Outdated
| return true; | ||
| } | ||
|
|
||
| bool Flatten2Op::InferShapeImpl() const { | ||
| FlattenOp::InferShapeImpl(); | ||
| auto x_shape = param_.x->dims().Vectorize(); | ||
| x_shape.insert(x_shape.begin(), 0); | ||
| param_.xshape->Resize(x_shape); | ||
| if (has_xshape_) param_.xshape->Resize(x_shape); |
There was a problem hiding this comment.
可以简化成这样？
if (param_.xshape)
param_.xshape->Resize(x_shape);
| return true; | ||
| } | ||
|
|
||
| bool Flatten2Op::AttachImpl(const cpp::OpDesc &opdesc, lite::Scope *scope) { | ||
| FlattenOp::AttachImpl(opdesc, scope); | ||
| param_.xshape = scope->FindMutableTensor(opdesc.Output("XShape").front()); | ||
| if (opdesc.HasOutput("XShape")) { |
There was a problem hiding this comment.
是不是可以参考
Paddle-Lite/lite/operators/reshape_op.cc
Line 173 in b0a3c98
这样是不是可以不用引入新的变量 has_xshape_ 了？
mjp9527
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
Host
PR types
Bug fixes
PR changes
OP
Description
Xshape is alternative for flatten op;