Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm] add v9 softmax implementation #9060

Merged
merged 13 commits into from
May 26, 2022

Conversation

chenjiaoAngel
Copy link
Collaborator

No description provided.

@paddle-bot-old
Copy link

Thanks for your contribution!

Copy link
Collaborator

@mjp9527 mjp9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

SVEXP_IMPL(svfloat32_t, f32)
SVEXP_IMPL(svfloat16_t, f16)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fp16前面应该加 #ifdef ENABLE_ARM_FP16吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,是的。我下个PR统一补上

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiaoAngel chenjiaoAngel merged commit d2b1c68 into PaddlePaddle:develop May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants