Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Add battery-electrochemical-performance prediction model #967

Open
wants to merge 1,367 commits into
base: develop
Choose a base branch
from

Conversation

huohuohuohuohuo123
Copy link

PR types

PR changes

Describe

HydrogenSulfate and others added 30 commits January 2, 2024 15:53
* add bubble datafile test=develop

* add bubble code test=develop

* add bubble code test=develop

* add bubble code test=develop

* add bubble code

* add bubble data

* add bubble code

* delete mat file

* delete mat file

* bubble code

* delete mat file

* add some modify

* add some modifications

* add some modifications

* add some modifications

* add some modifications

* add some modification

* add some modification

* add some modification

* add some modification

* add some modification

* add some modification(test=document_fix)

* add some modification

* add some modification

* add some modification

* add some modification

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop

* add some code test=develop
* Change the directory structure

* update phygeonet code

* update heat equation code

* update heat equation with bc code

* refine phygeonet code

* add callback for seed and logger
…med neural networks for the incompressible Navier-Stokes equations (PaddlePaddle#695)

* add

* add

* add

* add

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* a

* fix

* a

---------

Co-authored-by: wangguan <772359200@qq.com>
Co-authored-by: WG <39621324+wangguan1995@users.noreply.github.com>
* revert grid to scatter for plot can not solve unordered data

* add description for DeePMD-kit(paddle)

* add card for different kit

* update style
* add markdownlint into pre-commit

* fix documents by markdownlint

* fix typing and add create_graph&retain_graph in symbolic

* fix description for create_graph and retain_graph in docstring
* fix

* fix hydra

* fix bug

* fix

* fix

* fix

* fix

* doc fix
* support parallel grad to optimize grad computation with reducing common pathes in backward graph

* fix

* clean code

* update grad merge code for any common prefix numerator

* clean code

* update final code

* refine docstrings and variable & function name

* add graph_filename

* change heat_exchanger to sympy equation
* fix coner case for FusedDerivativeNode is placed at the end of nodes group

* add UT for fuse derivatives

* fix bug
* update phygeonet doc

* fix model name
* refine documents and remove redundant blankline toml

* refine more documents
* update quick_start

* convert all  sh

* update version note for release 2.6

* update optimizer usage code
* [Add] arch examples

* [Change] examples

* [Change] examples

* [Change] register_input_transform

* [Change] data with rand

---------

Co-authored-by: HydrogenSulfate <490868991@qq.com>
* [Add] phylstm examples

* [Change] phylstm examples

* [Change] remove blank line
* update docstring

* remove spaces in args

* update

* remove extra blank line
…ent Network for Solving Spatiotemporal PDEs (PaddlePaddle#674)

* Add files via upload

* Create readme.md

* Add files via upload

* Update __init__.py

* Add files via upload

* Add files via upload

* add

* add

* add

* add

* add

* add

* add

* add

* add

* add

* a

* a

* Update phycrnet.md

* Update phycrnet.md

* Update phycrnet.md

* a

* d

* d

* a

* a

* a

* a

* a

* a

* p

* a

* a

* a

* update .md file

* update .md file

* update .md file

* fix

* edit md

* eval

* m

* m

* edit

* edit

---------

Co-authored-by: WG <39621324+wangguan1995@users.noreply.github.com>
Co-authored-by: wangguan <772359200@qq.com>
* add 3 install method in README.md

* add more contributors
* (WIP)Add tutorial page

* fix document

* fix

* change split_to_dict and concat_to_tensor to staticmethod

* update batch_index class variable for all datasets

* move legend to outter-right of curve box and set dpi to 200

* add 1 more aistudio url
* update copyright header

* update docstring of PhyCRNet
@huohuohuohuohuo123
Copy link
Author

好的重新提交了

@luotao1 luotao1 self-assigned this Aug 13, 2024
@HydrogenSulfate
Copy link
Collaborator

@huohuohuohuohuo123 提交PR前请阅读开发指南,遵守基本的开发规范:https://paddlescience-docs.readthedocs.io/zh-cn/latest/zh/development/

@HydrogenSulfate
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.✅ HydrogenSulfate✅ Yang-Changhui✅ zhiminzhang0830✅ KennyNH✅ MayYouBeProsperous✅ cxxly✅ huohuohuohuohuo123✅ lijialin03✅ KaiCHEN-HT❌ github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.

@huohuohuohuohuo123 另外请签署一下CLA协议

@huohuohuohuohuo123
Copy link
Author

您好,仔细阅读了开发文档,请问具体哪里有什么问题

.gitattributes Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

空文件删除

examples/MLP Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. MLP是模型结构的名字,不能作为案例名
  2. 该文件夹是一个无效的submodule,请提交实际代码

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. MLP_Pipeline是模型结构的名字,不能作为案例名
  2. 该文件夹是一个无效的submodule,请提交实际代码

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

锂离子电池案例为什么需要改动这个文件呢?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. arch下面存放的是模型结构相关代码,请不要把整个案例代码复制进来
  2. PaddleScience是一个基于paddle深度学习框架开发的,请不要将基于tf、keras框架开发的代码提交上来

@@ -53,6 +53,9 @@
from ppsci.arch.vae import AutoEncoder # isort:skip
from ppsci.utils import logger # isort:skip

from ppsci.arch.xg_optuna import MyPaddleScienceXGBoostModel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PaddleScience已经集成了optuna自动调参工具:https://paddlescience-docs.readthedocs.io/zh-cn/latest/zh/user_guide/#21
  2. 问题同MLPModel.py
  3. MyPaddleScienceXGBoostModel不是一个有明确意义的文件命名,请更换成合适的名字

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题同MLPModel.py,不要将整个案例文件放到arch/下

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数据预处理代码可以跟案例代码放在一起,dataset/只存放Dataset相关的代码

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题同create_data.py

@HydrogenSulfate
Copy link
Collaborator

新增一个案例的代码可以参考 #964 , #962

@huohuohuohuohuo123
Copy link
Author

重新提交了

@HydrogenSulfate HydrogenSulfate changed the title 锂离子电池电极材料性能预测 [Example] Add battery-electrochemical-performance prediction model Aug 22, 2024
@leeleolay
Copy link

运行脚本这里辛苦转换成可执行py脚本文件吧,另外看到里面有很多tensorflow等其他框架代码,辛苦检查并修正一下。可以把测试结果和向光说明补充在在MLP_LI.md文档中。

@huohuohuohuohuo123
Copy link
Author

向光说明是什么意思?重新更新了,辛苦看一下还有哪里需要更改

@leeleolay
Copy link

向光说明是什么意思?重新更新了,辛苦看一下还有哪里需要更改

相关说明,打错字了不好意思。

@huohuohuohuohuo123
Copy link
Author

哦哦,麻烦看一下还有什么需要修改的地方

@leeleolay
Copy link

leeleolay commented Sep 27, 2024

现在提交的文件和说明文档的部分有些不太完整,文档格式上辛苦再检查一下,做一下修正和完善

@huohuohuohuohuo123
Copy link
Author

您好,文档部分的格式进行了一些修改,辛苦看一下,哪里是否需要修改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.