Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Add reference to UnitfulParsableString.jl #730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eben60
Copy link
Contributor

@Eben60 Eben60 commented Jun 2, 2024

No description provided.

@@ -31,6 +31,7 @@ mathematical operations and collections that are found in Julia base.

- [UnitfulEquivalences.jl](https://github.com/sostock/UnitfulEquivalences.jl): Enables conversion between equivalent quantities of different dimensions, e.g. between energy and wavelength of a photon.
- [UnitfulLatexify.jl](https://github.com/gustaphe/UnitfulLatexify.jl): Pretty print units and quantities in LaTeX format.
- [UnitfulParsableString.jl](https://github.com/michikawa07/UnitfulParsableString.jl): add method `Unitful.string` to convert `Quantity` (or some type) to parsable `String`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is unfortunate that the package extends Unitful.string. Not just because it is type piracy, but also because it is confusing (Unitful doesn’t define a string function, so Unitful.string is just Base.string. Calling it Unitful.string obfuscates what it is actually doing).

I have opened an issue about this: michikawa07/UnitfulParsableString.jl#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants