Expaut 14 #15
Open
Expaut 14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automation' to match file name; reloaded dependent genmodels accordingly
…rimentautomation.application.tooladapter.simucom.model'; the code will be now automatically generated to src-gen within each build
…rimentautomation'; the code will be now automatically generated to src-gen within each build
…rimentautomation.application.tooladapter.simulizar.model'; the code will be now automatically generated to src-gen within each build
…rimentautomation.edit'; the code will be now automatically generated to src-gen within each build
…rimentautomation.editor'; the code will be now automatically generated to src-gen within each build
…rimentautomation.application.tooladapter.simucom.model.edit'; the code will be now automatically generated to src-gen within each build
…rimentautomation.application.tooladapter.simulizar.model.edit'; the code will be now automatically generated to src-gen within each build
|
I have found this review request in my review queue. Apparently it is a few months old. Could you please provide a short description of what you PR tries to achieve? |
|
This PR is about 'Support automatic code generation' https://palladio-simulator.atlassian.net/browse/EXPAUTOM-14 |
sdkrach
suggested changes
Oct 8, 2021
There was a problem hiding this comment.
In principle, the changes look reasonable and make sense. However, it does not work for me. Did you run an actual experiment with the code? If I try to start one, it fails complaining about a missing ExperimentsResourceFactoryImpl. This might stem from a previous generated eclipse extension registration which is not valid anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review