Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggravated bleeding #8309

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Sep 19, 2024

This reworks how moving bleed is handled and adds support for Aggravated bleeding

If the enemy is moving it functions the same as before, (but better breakdowns, and fixes to the specter which it didnt work on)
If the bleeding is always aggravated (Gladiator, or party aggravate) then it applies the full effect

If however its not always aggravated, then it applies with a bleed stack potential of the number of hits it takes to aggravate on average less, eg if you have 100% chance to aggravate, then the stack potential is 1 less, if you have a 25% chance to, then its 4 less, and if you have a 10% chance to then its a stack potential of 10 less, this means getting more aggravate chance increases dps correctly, and gladiator or enemy moving is slightly stronger than 100% chance

3 issues remaining with this PR
Bleed stack potential override config isnt used directly for aggravated bleeds, and theres no way to set them incase something is wrong
Other hits dont aggravate bleeding, this is particularly notable for not being able to aggravate minions bleed damage with your attacks
The code is pretty messy, and might need to be redone

edit: it also doesnt handle the mastery to aggravate bleeds older than 4 seconds, Ill look into fixing that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant