Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug when embeding GitHub Gist #123

Closed
seisman opened this issue Jul 3, 2014 · 8 comments
Closed

a bug when embeding GitHub Gist #123

seisman opened this issue Jul 3, 2014 · 8 comments
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Milestone

Comments

@seisman
Copy link

seisman commented Jul 3, 2014

I am trying to embed GitHub Gist into rST files, below is the simplest example :

Test for Gist
#############                                                                       

.. raw:: html                                                                       

   <script src="https://gist.github.com/seisman/25337aa9df50fb6ec6c3.js"></script>

What I want to see looks like this:

gist0

But the actual result looks like this:
gist

It seems to be caused by the definition of table-layout property in elegant.css, so I comment out the table-layout property and it works fine now.

/* Syntax Highlight */                                                           
table {
//    table-layout: fixed;
      width: 100%;
}

I don not know much about CSS, so I am not sure whether this modification have possible side-effects or not.

@Schnouki
Copy link

Same issue. I added the following to my custom.css:

/* Gist */
.gist {
    font-size: .85em;
    line-height: 1.1em;
}
.gist table {
    table-layout: initial;
}

Works fine, and shouldn't affect anything else.

@silverhook
Copy link
Member

Is this still an issue with the latest code?

If so, I think it would make sense to implement @Schnouki’s fix and document it.

@talha131 talha131 added this to the Elegant 3.0 milestone Dec 28, 2018
@iranzo iranzo added the bug Well, it shouldn’t be doing that. Let’s fix it! label Jan 13, 2019
@talha131 talha131 modified the milestones: Roadmap, 2019 - Q4 Jun 17, 2019
@talha131 talha131 modified the milestones: 2019 - Q4, 2019 - Q3 Jul 5, 2019
@talha131
Copy link
Member

talha131 commented Jul 5, 2019

@all-contributors please add @seisman for bug

@allcontributors
Copy link
Contributor

@talha131

I've put up a pull request to add @seisman! 🎉

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

@all-contributors please add @Schnouki for code

@allcontributors
Copy link
Contributor

@talha131

I've put up a pull request to add @Schnouki! 🎉

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

0416433

@talha131 talha131 closed this as completed Jul 5, 2019
talha131 pushed a commit that referenced this issue Jul 14, 2019
# [3.1.0](V3.0.0...V3.1.0) (2019-07-14)

### Bug Fixes

* **article:** fix regression introduced in 7ca7331 ([2c23961](2c23961))
* **authors:** title attribute was not closed in quotes ([de1d05b](de1d05b))
* **gist:** embedded Github gist are not laid out correctly ([0416433](0416433)), closes [#123](#123)
* **reST:** indents in line blocks is not preserved ([e1429c5](e1429c5)), closes [#144](#144)

### Features

* **article:** make article subtitle italic ([7ca7331](7ca7331)), closes [#284](#284)
* **authors:** add line above authors section ([35a35b0](35a35b0))
* **authors:** add support for avatar ([cc92230](cc92230)), closes [#362](#362)
* **authors:** make authors URL nofollow ([07bf415](07bf415))
* **authors:** move authors below share links section ([b81555a](b81555a))
* **authors:** open author url in a new window ([f97b47a](f97b47a))
* **Chinese:** add better font support for Chinese language ([2711aa0](2711aa0)), closes [#134](#134)
* **modified:** show Last Updated only if the difference between created and modified is more than a day ([b0eac79](b0eac79))
* **monetization:** add BestAzon support ([6d8a23c](6d8a23c))
@talha131
Copy link
Member

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Development

No branches or pull requests

5 participants