-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add applause button support #532
Comments
I tried it a week or two ago. Then it wasn't working reliably. I was thinking of using the Google Analytics event tracker to implement this feature. Related to #522 |
Actually I didn't test it thoroughly or tried to reproduce the issue again. It could be a temporary issue or one my browser addons could be interfering with it. That's why I didn't open the issue there. |
Do you have any suggestion where to add it :) This is what I've tried. modified templates/article.html @@ -142,7 +143,8 @@
{{ freelists(article) }}
</div>
</section>
-</div>
+ <applause-button style="width: 58px; height: 58px;"/>
+ </div>
</article>
{% endblock content %} modified templates/base.html <link rel="stylesheet" type="text/css" href="{{ SITEURL }}/theme/css/custom.css" media="screen">
+ <link rel="stylesheet" type="text/css" href="https://unpkg.com/applause-button/dist/applause-button.css" media="screen">
{% endif %}
{% endblock head_links %}
{% include '_includes/favicon_links.html' %}
@@ -110,6 +111,7 @@
{% endif %}
<script src="//code.jquery.com/jquery.min.js"></script>
<script src="//netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/js/bootstrap.min.js"></script>
+ <script src="//unpkg.com/applause-button/dist/applause-button.js"></script>
<script>
function validateForm(query)
{ But the result looks so bad, I need to modify the css and learn where to put I checked that the green color comes from |
This should do elegant/templates/article.html Line 75 in 8e63305 |
My guess is that the CSS file for the applause button has not been added
correctly.
Try to see if `applause-button.css` is available in the production or not.
… |
No, it's in my local. I use CDN: modified templates/base.html
@@ -42,6 +42,8 @@
<link rel="stylesheet" type="text/css" href="{{ SITEURL }}/theme/css/elegant.css" media="screen">
<link rel="stylesheet" type="text/css" href="{{ SITEURL }}/theme/css/admonition.css" media="screen">
<link rel="stylesheet" type="text/css" href="{{ SITEURL }}/theme/css/custom.css" media="screen">
+ <!-- <link rel="stylesheet" type="text/css" href="{{ SITEURL }}/theme/css/applause-button.css"> -->
+ <link rel="stylesheet" href="https://unpkg.com/applause-button@3.3.0/dist/applause-button.css" />
{% endif %}
{% endblock head_links %}
{% include '_includes/favicon_links.html' %}
@@ -110,6 +112,8 @@
{% endif %}
<script src="//code.jquery.com/jquery.min.js"></script>
<script src="//netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/js/bootstrap.min.js"></script>
+ <!-- <script src="//unpkg.com/applause-button/dist/applause-button.js"></script> -->
+ <script src="https://unpkg.com/applause-button@3.3.0/dist/applause-button.js"></script>
<script>
function validateForm(query)
{
Am I missing something? |
Seems fine. No idea what's going on here. Perhaps, share the live version of the final output. That may help me zero in on the problem. |
I'm afraid I can't do that, as I don't have something like 'staging' version of it. I don't want my reader surprised by that clunky clap button while we're investigating it :( I will dig more locally. |
If you open a PR here, then netlify will automatically create a demo of it. You can read about this feature here. https://elegant.oncrashreboot.com/how-to-contribute#previewing-changes But of course, for this, you will have to work on adding the button to the elegant directly, instead of adding it to your site only. |
Yeah, that needs tweak. I will fix it once you resolve the issues I have pointed out in your PR.
should be bottom. "Following user scroll" is distracting. |
# [5.1.0](V5.0.1...V5.1.0) (2019-12-05) ### Bug Fixes * **applause:** applause_button tag does not auto close ([d37e691](d37e691)) * **typography:** make headings align to the left instead of justify ([101285e](101285e)) ### Features * **applause:** add option to set applause_button_id ([8eda9a4](8eda9a4)) * **applause:** add support for applause button ([e4872fd](e4872fd)), closes [#532](#532) * **applause:** simplify filter option ([9f8b60f](9f8b60f))
🎉 This issue has been resolved in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
https://applause-button.com/
The text was updated successfully, but these errors were encountered: