Add Python 3.10 CI builder and updated PL dep #186
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 4 4
Lines 293 293
=======================================
Hits 292 292
Misses 1 1 Continue to review full report at Codecov.
|
| @@ -7,14 +7,15 @@ on: | |||
| types: [published] | |||
|
|
|||
| env: | |||
| CIBW_BUILD: 'cp37-* cp38-* cp39-*' | |||
| CIBW_BUILD: 'cp37-* cp38-* cp39-* cp310-*' | |||
| CIBW_SKIP: "*-musllinux*" | |||
There was a problem hiding this comment.
For my understanding: what is being skipped here and for what reason?
There was a problem hiding this comment.
We skip attempting to build MUSL supported wheels (an alternative to the more common glibc linux distributions). MUSL is used in dists such as https://alpinelinux.org/. This can be enabled a little later when MUSL support is more further along.
There was a problem hiding this comment.
@antalszava Alpine Linux is typically used in Docker containers, so this is where MUSL compatibility is usually required
|
|
||
| # Testing of built wheels | ||
| CIBW_TEST_REQUIRES: numpy==1.19.5 scipy pytest pytest-cov pytest-mock flaky | ||
| CIBW_TEST_REQUIRES: numpy~=1.21 scipy pytest pytest-cov pytest-mock flaky |
There was a problem hiding this comment.
How come the NumPy version was updated?
There was a problem hiding this comment.
Version 1.19 has/had issues working with Py3.10. The previous choice for 1.19 was due to TF compatibility. With TF 2.7 now out in the wild, there is no more reason to pin to the older version (and I believe the PL repo is 1.21 in requirements.txt too https://github.com/PennyLaneAI/pennylane/blob/92e572f0cf8a0ba950ddd0e9440abfc1d9943c27/requirements.txt#L1).
|
|
||
| # Python build settings | ||
| CIBW_BEFORE_BUILD: | | ||
| pip install pybind11 ninja && yum install -y cmake gcc gcc-c++ | ||
| pip install pybind11 ninja |
There was a problem hiding this comment.
How come some installs were removed?
There was a problem hiding this comment.
GCC/G++ should already be available on these images, so no need to explicitly request anymore.
There was a problem hiding this comment.
In hindsight, I think it may be better to keep these explicitly in there. Thanks for noticing.
Co-authored-by: antalszava <antalszava@gmail.com>
Context: Closes #152
Description of the Change: Adds wheelbuilder support for Python 3.10, and updates the required PL version.
Benefits:
Possible Drawbacks:
Related GitHub Issues: