Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #234

Merged
merged 12 commits into from
Feb 16, 2022
Merged

Add Docker support #234

merged 12 commits into from
Feb 16, 2022

Conversation

maliasadi
Copy link
Member

Context:
Add Docker support to setup & test PL-Lightning.

Description of the Change:

  • Add Dockerfile
  • Update README
  • Update cmake/process_options.cmake
  • Update setup.py

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #234 (db35c2e) into master (2cb2727) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           4        4           
  Lines         354      354           
=======================================
  Hits          353      353           
  Misses          1        1           
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 99.62% <ø> (ø)
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb2727...db35c2e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2022

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   555 tests ±0     555 ✔️ ±0  0 💤 ±0  0 ±0 
2 289 runs  ±0  2 289 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit db35c2e. ± Comparison against base commit 2cb2727.

♻️ This comment has been updated with latest results.

@maliasadi maliasadi requested a review from mlxd February 14, 2022 14:47
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @maliasadi thanks for putting this together.
Just curious, how does one expect to use the Docker version of lightning?

Will this be strictly used for building wheels, building and running the test-suite, or having a fully capable Python environment with lightning installed from the given branch?

@maliasadi
Copy link
Member Author

maliasadi commented Feb 15, 2022

Will this be strictly used for building wheels, building and running the test-suite, or having a fully capable Python environment with lightning installed from the given branch?

Hey @mlxd. Thanks for the review. The main benefit of having such Docker file is that it eases the process of building an image with Python and Lightning installed in it. This may help developers to create images of their work and test on different machines. However, as told you before, I'm not sure if it's worth to be added to the master branch; as its use case for me is on AWS only.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi . I think it will be useful for local testing and dev also.

I'd suggest one change, placing the Dockerfile into a directory called docker in the same structure as the PennyLane repo. Happy to approve it and let it be merged after this.

@maliasadi maliasadi merged commit 5ffba5f into master Feb 16, 2022
@maliasadi maliasadi deleted the add_dockerfile branch February 16, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants