Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to remove JacobianTape #260

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Update tests to remove JacobianTape #260

merged 2 commits into from
Mar 16, 2022

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Mar 16, 2022

Context: With PennyLaneAI/pennylane#2336 deprecated functions in PennyLane were removed. Some of these functions were still in use in Lightning and needed replacement.

Description of the Change: Removes JacobianTape from the Lightning Python test suite and updates the support for new syntax.

Benefits: Passing tests

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #260 (f2ce6cc) into master (d0aede4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f2ce6cc differs from pull request most recent head 90a0c42. Consider uploading reports for the commit 90a0c42 to get more accurate results

@@            Coverage Diff            @@
##            master      #260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          366       366           
=========================================
  Hits           366       366           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0aede4...90a0c42. Read the comment docs.

@github-actions
Copy link
Contributor

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   555 tests ±0     555 ✔️ ±0  0 💤 ±0  0 ±0 
2 289 runs  ±0  2 289 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 90a0c42. ± Comparison against base commit d0aede4.

Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update!

@mlxd
Copy link
Member Author

mlxd commented Mar 16, 2022

Since this is a blocker on other work, I'll merge with the single approval.

@mlxd mlxd merged commit 27bc5f5 into master Mar 16, 2022
@mlxd mlxd deleted the jacobian_tape branch March 16, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants