Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bug-fix release 0.22.1 #275

Closed
wants to merge 2 commits into from
Closed

Create bug-fix release 0.22.1 #275

wants to merge 2 commits into from

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Mar 29, 2022

Context: Issues were observed with the identity gate in lightning & lightning GPU. This fix ensures the kernel is registered to C++ runtime.

Description of the Change: Adds Identity kernel as a no-op to dispatcher.

Benefits: Avoids runtime error of calling identity external to Python tooling.

Possible Drawbacks:

Related GitHub Issues:

@mlxd
Copy link
Member Author

mlxd commented Mar 29, 2022

NOTE: Many of the changes here are from the 0.22.0 release (ee0e442 and earlier commits), and so should be ignored.

@mlxd mlxd changed the base branch from master to v0.22_rc0 March 29, 2022 16:44
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd! Happy to approve this.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Happy to approve!

@chaeyeunpark
Copy link
Contributor

Hi @mlxd! Happy to approve this. Adding a gate actually takes some steps in Lightning now. Should think about how to reduce it...

@mlxd
Copy link
Member Author

mlxd commented Mar 29, 2022

Thanks all.

Since this has diverged somewhat from master, I will create a separate branch from here, update the required merge version and keep this branch to allow any further fixes as needed later.

@mlxd mlxd mentioned this pull request Mar 29, 2022
@mlxd mlxd closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants