-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qchem gates and generators #289
Conversation
Hello. You may have forgotten to update the changelog!
|
…ghtning into add_qchem_gates
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 99.18% 99.24% +0.06%
==========================================
Files 28 29 +1
Lines 3060 3330 +270
==========================================
+ Hits 3035 3305 +270
Misses 25 25
Continue to review full report at Codecov.
|
Thanks, @maliasadi for the great works! But can we merge this after my PR (#274) as it involves several changes in kernels? |
Sure thing @chaeyeunpark! |
Hi @maliasadi, I will review this PR when the changes in |
…ghtning into add_qchem_gates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @maliasadi for amazing work! I just have a few questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @maliasadi
Nothing major to add, just a single question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @maliasadi again for a great job! I just have one more question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. nice & clean code!
Context:
This PR adds all unsupported parameterised gates and generators for adjoint-diff including,
Benchmark: