Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ReadTheDocs runner version to Ubuntu 22.04 #327

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

rashidnhm
Copy link
Collaborator

@rashidnhm rashidnhm commented Aug 8, 2022

Context: Updated runner version of ReadTheDocs to Ubuntu 22.04

Description of the Change:
This pull request updates the runner that ReadTheDocs would use to build the pennylane-lightning docs. The reason for this update is to get the updates system packages (gcc, cmake, etc) available out of the box.

Installing and switching the default version of gcc in the ubuntu 20.04 is more cumbersome and require more "hacky" workarounds.

Benefits:
The pennylane-lightning docs build would pass for both RTD community and business plan. As is stands even though the docs are being built on the community runners, it is failing on the business plan runner.

Possible Drawbacks:
N/A. The build is passing on the business runners with the changes proposed in this Pull request.

Related GitHub Issues:
N/A.

@rashidnhm rashidnhm requested a review from mlxd August 8, 2022 15:40
@rashidnhm rashidnhm self-assigned this Aug 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±0             1 suites  ±0   2s ⏱️ ±0s
       956 tests ±0         956 ✔️ ±0  0 💤 ±0  0 ±0 
234 969 runs  ±0  234 969 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 45bf82a. ± Comparison against base commit e1f91ac.

♻️ This comment has been updated with latest results.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Rashid. Approving.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #327 (45bf82a) into master (e1f91ac) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          73       73           
  Lines        5115     5115           
=======================================
  Hits         5102     5102           
  Misses         13       13           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlxd mlxd merged commit 1c46f5a into master Aug 8, 2022
@mlxd mlxd deleted the fix-rtd-build-failure branch August 8, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants