Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests and checks CI/CD pipelines #353

Merged
merged 27 commits into from
Sep 21, 2022
Merged

Conversation

AmintorDusko
Copy link
Contributor

Context:
Checks and tests are, at the moment, slowing down the CI/CD pipeline.
Some have a running time greater than 20 minutes.

Description of the Change:
Introduction of Kokkos caching for tests and checks, and removal of redundancies.

Benefits:
The expected benefit is to have tests and checks running in less than 10 minutes.

Possible Drawbacks:
Not aware of any.

Related GitHub Issues:
#352

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@AmintorDusko
Copy link
Contributor Author

AmintorDusko commented Sep 14, 2022

[sc-25948]

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #353 (3ddc301) into master (4c6c154) will decrease coverage by 1.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   99.78%   98.39%   -1.40%     
==========================================
  Files          49       49              
  Lines        4160     4163       +3     
==========================================
- Hits         4151     4096      -55     
- Misses          9       67      +58     
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/lightning_qubit.py 100.00% <100.00%> (+0.37%) ⬆️
...ng/src/gates/cpu_kernels/GateImplementationsPI.hpp 94.74% <0.00%> (-5.26%) ⬇️
...ng/src/gates/cpu_kernels/GateImplementationsLM.hpp 96.11% <0.00%> (-3.89%) ⬇️
pennylane_lightning/src/util/Memory.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/BitUtil.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/RuntimeInfo.cpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/RuntimeInfo.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/ConstantUtil.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/algorithms/AlgUtil.hpp 100.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AmintorDusko AmintorDusko linked an issue Sep 14, 2022 that may be closed by this pull request
@PennyLaneAI PennyLaneAI deleted a comment from github-actions bot Sep 15, 2022
@AmintorDusko AmintorDusko marked this pull request as draft September 16, 2022 11:47
@AmintorDusko AmintorDusko marked this pull request as ready for review September 16, 2022 11:47
@AmintorDusko
Copy link
Contributor Author

I intend to fill the changelog and merge this PR only after the Release.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko
A few comments below. Also, it may be worth updating all the runner images from 20.04 to 22.04.

.github/workflows/benchmarks.yml Outdated Show resolved Hide resolved
.github/workflows/benchmarks.yml Outdated Show resolved Hide resolved
.github/workflows/format.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Show resolved Hide resolved
@AmintorDusko AmintorDusko marked this pull request as draft September 16, 2022 13:12
@AmintorDusko AmintorDusko changed the title Improve tests and checks workflows Improve tests and checks CI/CD pipelines Sep 20, 2022
Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @AmintorDusko! Just few comments.

@multiphaseCFD
Copy link
Member

Thanks @AmintorDusko for the nice work! No more comments from my side.

Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! I just have suggestions on the benchmark.

AmintorDusko and others added 3 commits September 20, 2022 17:11
Co-authored-by: Chae-Yeun Park <chae-yeun@xanadu.ai>
Co-authored-by: Chae-Yeun Park <chae-yeun@xanadu.ai>
Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @AmintorDusko! I think @mlxd needs to change the required CI names in the settings (ubuntu-20.24 to ubuntu-22.04).

@AmintorDusko
Copy link
Contributor Author

Thanks again @AmintorDusko! I think @mlxd needs to change the required CI names in the settings (ubuntu-20.24 to ubuntu-22.04).

@mlxd, I summon thee!

@mlxd
Copy link
Member

mlxd commented Sep 21, 2022

Should we be concerned about the coverage drop?

@AmintorDusko
Copy link
Contributor Author

AmintorDusko commented Sep 21, 2022

Should we be concerned about the coverage drop?

I don't think so. This PR did nothing directly regarding coverage.
This might be a case of proportional change and not an effective change on coverage.
We increased the amount of tests only.

@AmintorDusko
Copy link
Contributor Author

Should we be concerned about the coverage drop?

This might be work for other PR, though. The report shows that the drop in coverage is connected with cpu_kernels.

@mlxd mlxd merged commit 6f65a41 into master Sep 21, 2022
@mlxd mlxd deleted the Improvement/checks_and_tests branch September 21, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants