Improve Lightning package for external use #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4469 4469
=======================================
Hits 4464 4464
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
AmintorDusko
approved these changes
Nov 18, 2022
|
Hey @mlxd, nice work! |
multiphaseCFD
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: To allow Lightning to be used in external projects, and support compilation through Spack, we require some adaptions to the external package management, and how certain files are supported in targets. This PR allows better support for Lightning as an external library, usable with and without Python, and enabling inclusion of dependencies when available.
Description of the Change: Update to CMake targets, build variant supports, and Kokkos package inclusion.
Benefits: Improves extensibility of Lightning, and allows support for Spack.
Possible Drawbacks:
Related GitHub Issues: