-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create bug-fix release 0.26.1 #377
Conversation
[sc-27673] |
Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu 1 files + 1 1 suites +1 2s ⏱️ +2s Results for commit 510266d. ± Comparison against base commit 71a5a4f. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## v0.26.0-rc0 #377 +/- ##
===============================================
+ Coverage 90.94% 99.88% +8.93%
===============================================
Files 41 49 +8
Lines 3324 4196 +872
===============================================
+ Hits 3023 4191 +1168
+ Misses 301 5 -296
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @AmintorDusko , nice work! When compiling you branch, I got following errors: |
Hi @multiphaseCFD, the work is not done yet. This is a draft pull request. |
Thanks @AmintorDusko for putting these together! Just one mirror comments. |
What about "Defining a vector to be transposed." -> "Defining a tensor to be transposed." ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Amintor. Just some questions, but not blocking the approval.
Context: There is an issue with the returned probability in some edge cases.
Description of the Change:
Benefits: Right results.
Possible Drawbacks:
Related GitHub Issues:
#375