Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bug-fix release 0.26.1 #377

Closed
wants to merge 17 commits into from
Closed

Conversation

AmintorDusko
Copy link
Contributor

Context: There is an issue with the returned probability in some edge cases.

Description of the Change:

  • The transposition step will be fixed.
  • Probability integration tests expanded.
  • Transposition unit tests included.

Benefits: Right results.

Possible Drawbacks:

Related GitHub Issues:
#375

@AmintorDusko AmintorDusko linked an issue Oct 13, 2022 that may be closed by this pull request
@AmintorDusko
Copy link
Contributor Author

[sc-27673]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  +           1             1 suites  +1   2s ⏱️ +2s
       957 tests +       957         957 ✔️ +       957  0 💤 ±0  0 ±0 
235 001 runs  +235 001  235 001 ✔️ +235 001  0 💤 ±0  0 ±0 

Results for commit 510266d. ± Comparison against base commit 71a5a4f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #377 (510266d) into v0.26.0-rc0 (71a5a4f) will increase coverage by 8.93%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           v0.26.0-rc0     #377      +/-   ##
===============================================
+ Coverage        90.94%   99.88%   +8.93%     
===============================================
  Files               41       49       +8     
  Lines             3324     4196     +872     
===============================================
+ Hits              3023     4191    +1168     
+ Misses             301        5     -296     
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/src/util/Util.hpp 100.00% <100.00%> (ø)
pennylane_lightning/src/gates/Gates.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/Memory.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/BitUtil.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/gates/GateUtil.cpp 100.00% <0.00%> (ø)
pennylane_lightning/src/gates/GateUtil.hpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/RuntimeInfo.cpp 100.00% <0.00%> (ø)
pennylane_lightning/src/util/RuntimeInfo.hpp 100.00% <0.00%> (ø)
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@multiphaseCFD
Copy link
Member

multiphaseCFD commented Oct 13, 2022

Hi @AmintorDusko , nice work! When compiling you branch, I got following errors: error: no member named 'reverse_view' in namespace 'std::ranges'. Rolling back to your previous implementation will fix the issue.

@AmintorDusko
Copy link
Contributor Author

Hi @AmintorDusko , nice work! When compiling you branch, I got following errors: error: no member named 'reverse_view' in namespace 'std::ranges'. Maybe rolling back to your previous implementation will fix the issue.

Hi @multiphaseCFD, the work is not done yet. This is a draft pull request.

@AmintorDusko AmintorDusko marked this pull request as ready for review October 13, 2022 21:47
@AmintorDusko AmintorDusko requested a review from a team October 13, 2022 21:47
@multiphaseCFD
Copy link
Member

Thanks @AmintorDusko for putting these together! Just one mirror comments.

@multiphaseCFD
Copy link
Member

I didn't get it. Could you please expand on your question?

What about "Defining a vector to be transposed." -> "Defining a tensor to be transposed." ?

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amintor. Just some questions, but not blocking the approval.

pennylane_lightning/src/tests/Test_Util.cpp Show resolved Hide resolved
pennylane_lightning/src/util/Util.hpp Show resolved Hide resolved
pennylane_lightning/src/util/Util.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with probability returned by lightning
3 participants